Sandro/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-09-18 23:19:34 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

batman-adv: correct NET_RX_* NET_XMIT_* confusion

Browse Source 
batadv_recv_icmp_ttl_exceeded() is a receive function. It must therefore
return NET_RX_* and not NET_XMIT_*. And batadv_send_skb_to_orig() is an
xmit function and is returning NET_XMIT_*.

This doesn't change the behavior because both NET_RX_SUCCESS and
NET_RX_SUCCESS are using the same underlying value (0).

Signed-off-by: Sven Eckelmann <sven@narfation.org>
This commit is contained in:
Sven Eckelmann
2026-08-05 09:16:54 +02:00
parent 085a411216
commit 1c852e4a99
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
net/batman-adv/routing.c
+3 -3
View File
@@ -341,7 +341,7 @@ out:
* For traceroute-style ICMP echo requests, send a TTL exceeded reply back to
* the source. Other ICMP types are simply dropped.
*
* Return: NET_XMIT_SUCCESS if the reply was queued, NET_RX_DROP otherwise
* Return: NET_RX_SUCCESS if the reply was queued, NET_RX_DROP otherwise
*/
static int batadv_recv_icmp_ttl_exceeded(struct batadv_priv *bat_priv,
struct sk_buff *skb)
@@ -382,8 +382,8 @@ static int batadv_recv_icmp_ttl_exceeded(struct batadv_priv *bat_priv,
icmp_packet->ttl = BATADV_TTL;
res = batadv_send_skb_to_orig(skb, orig_node, NULL);
if (res == NET_RX_SUCCESS)
ret = NET_XMIT_SUCCESS;
if (res == NET_XMIT_SUCCESS)
ret = NET_RX_SUCCESS;
/* skb was consumed */
skb = NULL;