Sandro/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-09-18 23:09:29 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

gpib: lpvo_usb_gpib: use memdup_user() instead of kmalloc() and copy_from_user()

Browse Source 
Use memdup_user() to replace the open-coded kmalloc() and
copy_from_user() sequence.

This simplifies the code while preserving the existing behavior.

This issue was reported by memdup_user.cocci.

Signed-off-by: Mohammad Shahid <mdshahid03@gmail.com>
Link: https://patch.msgid.link/20260705051701.142070-1-mdshahid03@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Mohammad Shahid
2026-07-17 14:54:05 +02:00
committed by Greg Kroah-Hartman
parent a168e2cfb7
commit 9d4ce1c7cd
1 changed files with 3 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
+3 -8
View File
@@ -1811,14 +1811,9 @@ static ssize_t lpvo_write(struct file *file, const char __user *user_buffer,
dev = file->private_data;
buf = kmalloc(count, GFP_KERNEL);
if (!buf)
return -ENOMEM;
if (copy_from_user(buf, user_buffer, count)) {
kfree(buf);
return -EFAULT;
}
buf = memdup_user(user_buffer, count);
if (IS_ERR(buf))
return PTR_ERR(buf);
rv = lpvo_do_write(dev, buf, count);
kfree(buf);